[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Modified export behavior

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-11-16 19:08:54 CET

On Sunday 16 November 2003 12:57, Philip Martin wrote:
> John Szakmeister <john@szakmeister.net> writes:
> > + if (mime_type && svn_mime_type_is_binary
> > (mime_type->data)) + {
> > + SVN_ERR (svn_io_copy_file (base,
> > + copy_to,
> > + TRUE,
> > + subpool));
> > + }
>
> I don't think the "if binary do this else do that" is necessary.
> Binary files won't have keywords, eol-style and copy_and_translate
> will just do a copy_file. Did you copy this pattern from elsewhere in
> the code?

Actually I did. I saw this pattern being used in svn_client_cat() in
libsvn_client/cat.c. I had thought about removing it, but my impression was
that it was some sort of safety precaution against someone specifying
keywords on a binary file. If that's not the case, I'll chuck it.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 16 19:05:32 2003

This is an archived mail posted to the Subversion Dev mailing list.