[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: send_xml returns void in mod_dav_svn/update.c?

From: <kfogel_at_collab.net>
Date: 2003-11-11 00:46:50 CET

Greg Stein <gstein@lyra.org> writes:
> No particular reason. The potential for an error condition there is pretty
> small. Although (thinking about it), if the connection was terminated, you
> could abort the report process. (the brigade function has a fast-path
> return, but you'd still chunk thru the FS work)
>
> Changing it to an svn_error_t, and propagating that should be just fine.
> I'd suggest that somewhere in the chain of callers of send_xml(), somebody
> should use use SVN_ERR_W() to target what was going on.

Thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 11 01:28:34 2003

This is an archived mail posted to the Subversion Dev mailing list.