[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: send_xml returns void in mod_dav_svn/update.c?

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-11-11 00:44:49 CET

On Mon, Nov 10, 2003 at 04:08:43PM -0600, kfogel@collab.net wrote:
> Greg, any idea why we ignore the result from apr_brigade_vprintf() and
> just return void from send_xml() in this mod_dav_svn/update.c code:
>...
> Almost all callers of send_xml() return (svn_error_t *), so if it
> returned an error we would have a way to propagate that error.
>
> But, there's probably some reason it's void?...

No particular reason. The potential for an error condition there is pretty
small. Although (thinking about it), if the connection was terminated, you
could abort the report process. (the brigade function has a fast-path
return, but you'd still chunk thru the FS work)

Changing it to an svn_error_t, and propagating that should be just fine.
I'd suggest that somewhere in the chain of callers of send_xml(), somebody
should use use SVN_ERR_W() to target what was going on.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 11 00:45:22 2003

This is an archived mail posted to the Subversion Dev mailing list.