[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] part of issue #897: errors could be better.

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-11-09 22:23:21 CET

"Erik Huelsmann" <e.huelsmann@gmx.net> writes:

> This point was brought up by Greg Hudson, on the thread the issue
> points to, but also yesterday on IRC.
>
> There's nothing wrong with the general error, but the general error
> duplicates the information in the specific error. Very often output
> can be expected along the lines of:
>
> svn: File not found
> svn: Can't find file 'foo'
>
> When you want to clean up error messages, you should consider being
> clear and brief.

Clear yes, but why brief?

> Brevity is not what you get when repeating yourself in output error
> messages.

If repetition is such a crime, how about

  svn: File not found
  svn: 'foo'

Suppose we are returning an SVN_ERR_FOO error, at present the general
error error text allows us to identify the error as a FOO error. If
the FOO error is generated in several places there will no longer be a
single message that identifies a FOO error. Can you explain why this
is clearly an improvement?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 9 22:24:06 2003

This is an archived mail posted to the Subversion Dev mailing list.