[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] part of issue #897: errors could be better.

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2003-11-09 21:48:31 CET

This point was brought up by Greg Hudson, on the thread the issue points to,
but also yesterday on IRC.

There's nothing wrong with the general error, but the general error
duplicates the information in the specific error. Very often output can be expected
along the lines of:

svn: File not found
svn: Can't find file 'foo'

When you want to clean up error messages, you should consider being clear
and brief. Brevity is not what you get when repeating yourself in output error
messages.

bye,

Erik.

> "Erik Huelsmann" <e.huelsmann@gmx.net> writes:
>
> > [[[
> > message if one is supplied, in favor of printing both - almost
> > equal - general and specific messages.
>
> I'm not sure why we would want to make this change.
>
> > for line in err_output:
> > - if re.match('svn: Filesystem has no item$', line):
> > + if re.search('was not found in the repository at revision', line):
> > break
> > else:
> > raise svntest.Failure
>
> What's wrong with having the general message?
>
> --
> Philip Martin
>

-- 
NEU FÜR ALLE - GMX MediaCenter - für Fotos, Musik, Dateien...
Fotoalbum, File Sharing, MMS, Multimedia-Gruß, GMX FotoService
Jetzt kostenlos anmelden unter http://www.gmx.net
+++ GMX - die erste Adresse für Mail, Message, More! +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 9 21:49:04 2003

This is an archived mail posted to the Subversion Dev mailing list.