Re: svn commit: rev 7482 - in trunk: subversion/bindings/swig/python/svn tools/hook-scripts/mailer

On Wed, Oct 22, 2003 at 12:30:14PM -0500, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/bindings/swig/python/svn/repos.py Wed Oct 22 12:30:10 2003
>...
> +### hide these names?
> +import string
> +import svn.fs
> +import svn.core
> +import svn.delta

It would be a bit tricky to delete them (since the methods need them at
runtime rather than just module-load time), but it would be possible to
use a different name.

> +class RevisionChangeCollector(svn.delta.Editor):
> +
> + # BATON FORMAT: [path, base_path, base_rev]
> +
> + def __init__(self, fs_ptr, rev):
> + self.fs_ptr = fs_ptr
> + self.rev = rev
> + self.changes = { } # path -> ChangedPathEntry()
> + self.roots = { } # revision -> svn_fs_root_t

You aren't using this cache.

If we think that the code in delete_entry will be "fast enough", then I'd
say we lose the cache. Otherwise, we'll need to find a pool to hold the
cached roots (which may, in turn, cause other problems).

All that said... way cool! I'm quite happy to see this "moved up" into the
mainline code. This is the kind of stuff that the svn.FOO modules are for:
add useful logic on top of the base SVN libraries.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org