[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn blame should call the cancel callback more often

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2003-10-19 00:26:06 CEST

On Sat, Oct 18, 2003 at 06:53:47PM +0200, SteveKing wrote:
> Hi,
>
> While trying out the new svn blame command (thanks for that btw!)
> I noticed that it can't be cancelled - the cancel callback is only
> called when the log is fetched, but that's it. Later in the time consuming
> diff task the callback is not called anymore and so the user
> can't really cancel the operation.

Before r7438, the cancel callback was called between each fulltext
retrieval. I realized earlier today that the restructuring done in
r7438 lost that feature. I'll put it back in.

> Just as a sidenote: it would even be better if in that for() loop another
> callback
> would be called to tell the client(s) which revision is currently worked on,
> maybe
> even together with the total amount of revision. That would give the clients
> a
> chance to show some progress information...

That's a great suggestion. I'll look into it.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 19 00:26:49 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.