[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: request for small API change

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2003-10-19 00:20:51 CEST

On Sat, Oct 18, 2003 at 02:06:42PM +0200, SteveKing wrote:
> Hi,
>
> I noticed that the new function "svn blame" has a callback
> function which provides the date as a string. I think this
> should be changed so that an svn_time_t value is returned
> instead of a string. That way clients can create a string
> for a date as they want (e.g. with localization).
> I think formatting dates/times to strings should be left
> to each client and not go into the subversion library itself.
>
> What do you think? Good or bad idea?
>
> while at it: the svn_log_message_receiver_t callback
> also returns the date as a string - that should be changed
> too. I haven't found any other place where the date is
> returned as a string but I'm not sure if I found all of them.
>

svn_client_blame() just passes on the data that it gets from the
log_message_receiver callback; when/if that changes, it will be
trivial to change blame to pass a different datatype.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 19 00:21:43 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.