Re: Catching dangling transactions

Philip Martin wrote:
> Philip Martin <philip@codematters.co.uk> writes:
>
>>After reading svn_repos.h, it appears to be the callers responsibilty.
>>In that case the problem is probably in svn_wc_crawl_revisions, all
>>those SVN_ERRs bypass the abort_report: processing, in this particuar
>>case the reporter->finish_report call is the culprit.
>
> I'm trying this

You'll put a "what and why" line here at the top of the log message, won't you?

> * subversion/libsvn_wc/adm_crawler.c
>
> (wc_crawl_revisions): New function containing the bulk of the old
> svn_wc_crawl_revisions but without the abort_reporter handling.
>
> (svn_wc_crawl_revisions): Now a wrapper that calls the new
> wc_crawl_revisions and then abort_reporter if there is an error.

Wow, that's a quick fix! (Yes, it does fix my test case.)

No need for the "wc_" prefix on the static function, but if that's all I can think of by way of constructive criticism it must be time to commit it, unless you can spot other similar cases already.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 12 03:32:46 2003