[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Detecting unhandled errors, WAS: RE: svn commit: rev 7373 - trunk/subversion/libsvn_client

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2003-10-10 21:53:02 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> On Fri, 2003-10-10 at 15:24, Sander Striker wrote:
> > My vote is for:
> >
> > static apr_status_t err_abort(void *data)
> > {
> > abort();
> > }
>
> A couple of remarks:
>
> * We should expect this to introduce a period of instability into our
> client when we first introduce it. Perhaps it should be limited to
> enable-maintainer-mode builds at least for a while.
>
> * If we ever enable it for non-maintainer-mode builds, perhaps spewing
> to stderr and exiting would be better than an abort() for those builds.
>
> * This will catch errors dropped by applications as well as errors we
> drop in our own libraries. (At least, if the applications perform an
> APR shutdown.) That might be considered a little unfriendly; there are
> many cases where an application doesn't need to care about a small
> amount of leaked memory, particularly when it only happens a constant
> number of times.

Hmm... good points, all. Must think on these things.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 10 21:54:15 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.