Re: Detecting unhandled errors, WAS: RE: svn commit: rev 7373 - trunk/subversion/libsvn_client

On Fri, 2003-10-10 at 15:24, Sander Striker wrote:
> My vote is for:
>
> static apr_status_t err_abort(void *data)
> {
> abort();
> }

A couple of remarks:

  * We should expect this to introduce a period of instability into our
client when we first introduce it. Perhaps it should be limited to
enable-maintainer-mode builds at least for a while.

  * If we ever enable it for non-maintainer-mode builds, perhaps spewing
to stderr and exiting would be better than an abort() for those builds.

  * This will catch errors dropped by applications as well as errors we
drop in our own libraries. (At least, if the applications perform an
APR shutdown.) That might be considered a little unfriendly; there are
many cases where an application doesn't need to care about a small
amount of leaked memory, particularly when it only happens a constant
number of times.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 10 21:49:36 2003