[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7296 - trunk/subversion/bindings/swig

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-10-06 21:15:00 CEST

On Sat, Oct 04, 2003 at 01:25:16PM -0500, rey4@tigris.org wrote:
> Author: rey4
> Date: Sat Oct 4 13:25:15 2003
> New Revision: 7296
> Modified:
> trunk/subversion/bindings/swig/core.i
> Log:
> Make python svn_config_get_config return an opaque pointer to the apr hash
> of config options instead of converting the hash to a python dictionary.
> Change motivated by discussion with Barry Scott <barry@barrys-emacs.org>
> on the user's list.

1) Development changes should be discussed on dev@, NOT the users list.
   Some of the developers are not subscribed to the users list, so they
   will not be privy to the suggested changes.

2) After reviewing the thread and the impetus for this change, I disagree.
   The change should be to enable storing a dictionary into
   client_ctx.config rather than adjusting the return value of get_config.
   Python programs have no way to inspect an apr_hash_t -- they should
   *all* be converted to dictionaries on return from SWIG, and *all*
   inputs should allow for a Python dictionary.

I'd ask that this change is reverted, and the logic for ctx.config be
updated to accept a Python dictionary.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 6 21:19:43 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.