Re: svn commit: rev 7292 - in trunk/subversion: include libsvn_subr

On Sun, Oct 05, 2003 at 11:07:48PM -0500, B. W. Fitzpatrick wrote:
> "Daniel L. Rall" <dlr@finemaltcoding.com> writes:
> > B. W. Fitzpatrick wrote:
> > > Garrett Rooney <rooneg@electricjellyfish.net> writes:
> > ...
> > >>Of course if you had just edited the svn:log revprop instead of using
> > >>the CGI that does svnadmin setlog, we all would have known that already ;-)
> > >
> > > I'm +0.5 on either disabling that script or reworking it to use the
> > > revprop stuff anyway.

+1

>...
> AFAIK, It's nothing but a convenience at this point (and my main reason
> for pulling/reworking it would be that it's not as accountable as the
> --revprop change method (yes, it writes changes to a file, but it
> doesn't send a commit message).

Agreed. I remember harping on Karl for similarly editing log messages
"behind the scenes". His "justification" for not using --revprop was that
the commit message didn't send a diff.

But what it *does* send is more than the CGI.

Oh, note that the CGI can do its magic even while revprop changes are
disabled (no hook in place). But for the SVN repos, we *have* that hook,
so I think the CGI ought to go.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org