Re: [PATCH] mark executable files as such in svn_load_dirs

Alexey Mahotkin wrote:
>
> Hello,
>
> While importing GNU trees, we should mark `configure' and friends as
> executable files.

Hi Alexey,

Thanks, applied in revision 7266 with some modifications. Some
commens on the patch to make the committers life easier are below:

>
> 2003-10-01 Alexey Mahotkin <alexm@hsys.msk.ru>
>
> * svn_load_dirs:

Please use the full path to the script in the log message.

> Add svn:executable property to executable files during import.
>
> Index: svn_load_dirs
> ===================================================================
> --- svn_load_dirs (revision 70)
> +++ svn_load_dirs (working copy)
> @@ -964,6 +964,17 @@
> last if $property->{control} eq 'break';
> }
> }
> +
> + # mark executable files as such
> + if (($source_type eq 'f') && (-x $source_path)) {
> + print "Adding to `$source_path' property `svn:executable' with value `yes'\n";
> + my $property = {
> + name => 'svn:executable',
> + value => 'yes',

I set the value to '' instead of 'yes', which implies that you can
set the value to 'no' and it'll remove the executable bit on the
file, which is not the case.

> + };
> + push (@{$add_files{$source_path}{properties}},
> + $property);
> + }
> }

Please honor the indentation style of the file you are working on.
This one uses the GNU coding standard described in the HACKING
file.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org