Re: Neon does not build on windows?

On Mon, Sep 29, 2003 at 09:40:31PM +0100, Barry Scott wrote:
> Joe,
>
> You need to patch config.hw, as config.hw.in is not used.
> I was wrong about winbase.h. I ended up including <windows.h>
> to make sure all defines are included.
>
> I guess that the reason why neon builds with openssl is that
> the include of <windows.h> in the openssl code leaks definitions
> into neon.

OK, thanks Barry, I've just added:

#ifdef WIN32
#include <windows.h> /* for GetCurrentThreadId() etc */
#endif

to ne_auth.c. (config.hw.in gets substituted into config.hw at
release time so that route would work if done right)

> I find this leakage of definitions leads to
> support issues for a code base; APR hides platform defines from
> the subversion code I believe.

Not really, APR headers #include system headers all over the place.

> I think you also need a comment to explain the use of Thread ID
> as a pid. Why is a process ID ok on a posix platform but not on
> windows?

Simply because it's much more work to get a thread ID on Unix platforms.
:)

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 23:07:19 2003