Joe,
You need to patch config.hw, as config.hw.in is not used.
I was wrong about winbase.h. I ended up including <windows.h>
to make sure all defines are included.
I guess that the reason why neon builds with openssl is that
the include of <windows.h> in the openssl code leaks definitions
into neon. I find this leakage of definitions leads to
support issues for a code base; APR hides platform defines from
the subversion code I believe.
I think you also need a comment to explain the use of Thread ID
as a pid. Why is a process ID ok on a posix platform but not on
windows?
BArry
At 25-09-2003 23:09, Joe Orton wrote:
>On Thu, Sep 25, 2003 at 09:55:54PM +0100, Barry Scott wrote:
> > Branko,
> >
> > From the sources in the tar ball and the instructions posted I am
> > failing to build on windows. I'll debug this and post instructions
> > that work with a tar ball on windows in a clean setup for anyone to
> > follow.
> >
> > Please post how you do the build, junctions and cygwin are not
> > a problem I understand both. I'll try and reproduce.
> >
> > The ne_auth.h problem is that winbase.h is not included anywhere
> > in the neon build so DWORD and GetCurrentThreadId are unknown.
>
>OK, does this patch work?
>
>Index: config.hw.in
>===================================================================
>RCS file: /home/cvs/neon/config.hw.in,v
>retrieving revision 1.13
>diff -u -r1.13 config.hw.in
>--- config.hw.in 29 Aug 2002 22:58:06 -0000 1.13
>+++ config.hw.in 25 Sep 2003 22:05:22 -0000
>@@ -33,6 +33,7 @@
> #define HAVE_LIMITS_H
> #define HAVE_STDLIB_H
> #define HAVE_STRING_H
>+#define HAVE_WINBASE_H
>
> #define HAVE_MEMCPY
>
>Index: src/ne_auth.c
>===================================================================
>RCS file: /home/cvs/neon/src/ne_auth.c,v
>retrieving revision 1.85
>diff -u -r1.85 ne_auth.c
>--- src/ne_auth.c 2 Sep 2003 19:21:26 -0000 1.85
>+++ src/ne_auth.c 25 Sep 2003 22:08:22 -0000
>@@ -46,6 +46,10 @@
> #include <unistd.h> /* for getpid() */
> #endif
>
>+#ifdef HAVE_WINBASE_H
>+#include <winbase.h> /* for GetCurrentThreadId etc */
>+#endif
>+
> #ifdef NEON_SSL
> #include <openssl/rand.h>
> #endif
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 22:42:01 2003