[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "svn commit" should always prompt after popping up a log message editor

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2003-09-29 17:03:47 CEST

On Mon, Sep 29, 2003 at 09:09:55AM -0400, mark benedetto king wrote:
> On Sat, Sep 27, 2003 at 02:29:58PM +0100, Philip Martin wrote:
> > mark benedetto king <mbk@lowlatency.com> writes:
> >
> > > This seemed like such a good idea that I went to implement it, and
> > > guess what? It was ALREADY implemented, just with an off-by-one bug!
> >
> > Is the user expected to know that this is an option for aborting a
> > commit? Should this be documented, and if so how? Should we add a
> > description of the behaviour to the default log message?
>
> Well, the whole $SVN_EDITOR interaction is, AFAIK, only documented in
> The Book, so that's probably where things should go. This change is
> probably worth a CHANGES entry, too. I'll put together a patch for
> the book.

This is the only place I found that already referenced the confirmation
message. Do you think this change is enough?

* doc/book/book/ch03.xml:
  Mention that empty log messages will trigger the abort/edit/continue
  prompt.

Index: doc/book/book/ch03.xml
===================================================================
--- doc/book/book/ch03.xml (revision 7202)
+++ doc/book/book/ch03.xml (working copy)
@@ -1556,7 +1556,9 @@
       <tip>
         <para>If you're in your editor writing a commit message and
           decide that you want to cancel your commit, you can just
- quit your editor without saving changes.</para>
+ quit your editor without saving changes. If you've already
+ saved your commit message, just save an empty message on top
+ of it.</para>
 
         <screen>
 $ svn commit

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 17:05:12 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.