Re: "svn commit" should always prompt after popping up a log message editor

On Sat, Sep 27, 2003 at 02:29:58PM +0100, Philip Martin wrote:
> mark benedetto king <mbk@lowlatency.com> writes:
>
> > This seemed like such a good idea that I went to implement it, and
> > guess what? It was ALREADY implemented, just with an off-by-one bug!
>
> Is the user expected to know that this is an option for aborting a
> commit? Should this be documented, and if so how? Should we add a
> description of the behaviour to the default log message?

Well, the whole $SVN_EDITOR interaction is, AFAIK, only documented in
The Book, so that's probably where things should go. This change is
probably worth a CHANGES entry, too. I'll put together a patch for
the book.

Changing EDITOR_EOF_PREFIX ("--This line...") seems reasonable, but I
remember the text being the subject of extensive debate in the past.

My suggestion, in light of this change:

--This line, and those below, will be ignored. An otherwise empty --
--log message will require confirmation before the commit proceeds. --

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 15:10:35 2003