Files wrote:
> Ok. Maybe someone needs to explain this to me once and for all.
>
> I was backlogging the changes made over the course of 6982-current.
>
> Was I supposed to go back and fix all the log messages that didn't
> contain enough information? OMG. You can't be serious.
Actually, we are. The entire point of having log messages is so someone
can look at each revision in the repository and see what the reason
behind the change was.
> Where are all the critics when you need 'em BEFORE you make the change.
What are you asking for, us to just know what kind of mistakes you are
going to make before you make them?
>>When the change is spread over several files then start with a brief
>>(one sentence, perhaps two) overview of the change.
>>
>>"Update Madrake package build to add support for Java." or whatever
>>this change did.
>
>
> How about "IT FREAKING JUST DID NOT WORK UNTIL I FIXED IT. IT WAS
> COMPLETELY BUSTED. I FIXED IT OUT OF THE GOODNESS OF MY HEART. IF YOU
> WOULD LIKE IT BACK THE WAY IT WAS LET ME KNOW."
Yelling at people is not likely to get you a useful response.
> I apologize, but Ben NEVER asked me to put something on top.
Perhaps not, but people have asked you to review existing log messages
in the repository so you can see how they should be done. For a
nontrivial change those log messages have a short statement at the top
stating what is being done.
>>I'm not really interested in Mandrake or Java, I tend to ignore the
>>dev list emails about them. As far as I can tell you have added some
>>sort of Java patch (fairly large) to the Madrake build. What does it
>>do? Did you write it? Did someone else? I should be able to tell
>>from the log message, just a single sentence summary will do.
>>
>>I must admit I don't understand why you need to make such extensive
>>changes to the build system in order to build Mandrake packages.
>
>
> There is a patch that's been floating around in this discussion. It
> modifies the javahl directory in the subversion/bindings/java.
>
> Since *I* don't own the patch, I simply added it so that at least a
> Mandrake JAVAHL RPM could be built. I will be removing it as soon as the
> patch is finalized.
If the patch has not been committed by the maintainers of that code,
then it's probably because it is not yet ready. Adding it in to the
packaged versions you intend people to use is just short circuiting the
process we use to make changes to the software, and seems like a bad
idea to me.
> Will someone at least for once tell me what the membership of the Log
> Police is and who is in charge?
Nobody is in charge, this is a community project and we work by
consensus. The people who have been correcting you are all respected
members of that community who have been around here a lot longer than
you have. As others have said already, perhaps you should settle down
and lurk on the lists for a while so you can get an idea how things are
generally done around here. It really is the best way to learn.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 29 02:24:07 2003