Re: "svn commit" should always prompt after popping up a log message editor

mark benedetto king <mbk@lowlatency.com> writes:
> The scenario is this: you're in $EDITOR, writing the log message. You
> suddenly realize that you don't want to commit, but you've incrementally
> saved the log message as you were typing it. I don't know about
> your $EDITOR, but my $EDITOR doesn't have (AFAIK) an "exit with error"
> feature.

Yah, something along the lines of

   $ kill -9 editor_pid
   $ svn cleanup ...

or

   $ kill -9 svn_pid
   $ svn cleanup ...

as you noted.

> What I do right now is open another window and kill the svn commit.
> Then I have to svn cleanup, but at least the commit doesn't happen.

I have an idea to avoid even the possibility of habituation:

When the log message is left empty, then svn would prompt

   "Empty log message -- c)ontinue, a)bort, ...?"

And, in the log message template, the one that says everything
following this line is ignored blah blah blah, we can have a note
telling the user to that saving an empty log message will cause svn to
prompt before committing.

I'm not volunteering to implement this, or even to review the patch.
I think the process-kill solution is Good Enough For Now.

> As an aside, I have another problem: I'm in $EDITOR, writing the
> log message.
> I realize (belatedly) that I'd sure like to see the results of "svn diff"
> (Ideally, :r!svn diff), but I can't, because the WC is locked. So I have to
> do the same kill/cleanup procedure.

Hmmm. I think the WC shouldn't be locked during that time, but am not
sure what is involved in fixing that.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 26 00:51:54 2003