[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "svn commit" should always prompt after popping up a log message editor

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2003-09-25 23:52:40 CEST

On Thu, Sep 25, 2003 at 01:51:11PM -0500, kfogel@collab.net wrote:
> David Summers <david@summersoft.fay.ar.us> writes:
> > That's the part that always gets me. My fingers are trained to save often
> > and it is proving very difficult to break them of that habit. When it is
> > saved then the commit goes on through....I've had quite a few
> > unintentional commits because of that. :-(
>
> No, it's when the editor process exits without error, not when the
> file is saved. (You can save it N times, but you only exit once.)
>
> > Maybe if it could re-ask when the editor is exited? (Or has this already
> > been discussed?)
>
> If you haven't realized by the end of your log message that you don't
> want to commit, I'm not sure that adding Yet Another Confirmation
> Moment is going to do a lot of good. Your fingers will quickly
> habituate to answering 'y' to that too, and you'll be right back where
> you started.

The scenario is this: you're in $EDITOR, writing the log message. You
suddenly realize that you don't want to commit, but you've incrementally
saved the log message as you were typing it. I don't know about
your $EDITOR, but my $EDITOR doesn't have (AFAIK) an "exit with error"
feature.

What I do right now is open another window and kill the svn commit.
Then I have to svn cleanup, but at least the commit doesn't happen.

As an aside, I have another problem: I'm in $EDITOR, writing the log message.
I realize (belatedly) that I'd sure like to see the results of "svn diff"
(Ideally, :r!svn diff), but I can't, because the WC is locked. So I have to
do the same kill/cleanup procedure.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 26 00:25:09 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.