Julian Foad <julianfoad@btopenworld.com> writes:
> I noticed that "diff -rCOMMITTED" is explicitly forbidden but "diff
> -rPREV" is allowed, and asked if there is a good reason for this. I
> proposed to remove the check that forbids "diff -rCOMMITTED".
> C-Mike Pilato said that would be wrong and asked what its meaning
> would be when used with a URL input path.
>
> 1. Do we agree that COMMITTED means "the newest revision in which
> the item was changed before or at the BASE revision in this working
> copy"? I believe this is how it is implemented. If so, it has no
> meaning for a target that is specified by a URL, only for a target
> that is specified by a local path. On a target specified by a local
> path, "diff -rCOMMITTED", if not forbidden, would work just as well
> as "diff -rPREV" does.
I think it's fine, yeah. Just because it can't work for URLs doesn't
mean it's not useful for wc paths.
> 2. Do we agree that, according to its definition, the version of a
> file referenced by "-rCOMMITTED" is always the same version that is
> referenced by "-rBASE"? By "version" I mean content and properties.
> (I do not mean the physical access method - whether it is read from
> the WC admin area as "text base" or is retrieved from the repository
> - as I consider that to be an implementation detail called
> "caching".)
Yup. When either COMMITTED or BASE is used, it should be possible to
get the data locally, without referring to the repository.
> 3. Are we willing to accept that, from the user's point of view, it
> does not matter whether the source of text for a "diff -rBASE" comes
> from the cache (text-base) or directly from the repository, as long
> as it is the correct content? I feel that the current
> implementation is a little biased toward the notion that "-rBASE"
> must be retrieved from the WC text-base, and "-rN" must be retrieved
> from the repository even if N==BASE.
+1 The current behavior could/should be optimized.
> If "we" answer these questions in the affirmative, then I will want
> to remove the prohibition of "-rCOMMITTED" from do_diff, and work
> gradually* towards accessing the text-base cache when any revision
> kind resolves to the right version. But we can discuss that later
> if necessary.
Bless you :-).
> [* After all bug fixing is finished, of course :-)]
Bless you squared!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 24 23:41:13 2003