Quoting John Peacock <jpeacock@rowman.com>:
> Branko �ibej wrote:
> >>+ printf ("WARNING: --owner and --group unavailable under
> Win32");
> >
> > 1. This warning isn't restricted to Win32 any more
>
> Good point. How does "...unavailable on this platform" sound?
Sounds good.
> > 2. Use svn_handle_warning instead of printf
>
> I see lots of examples using "printf()" and "fprintf(stderr," in the
> commandline tools, and very few examples of using svn_handle_warning().
> Since the error is
> not being thrown by one of the svn_* functions, it didn't seem
> appropriate to
> use that wrapper. There is always a point where encapsulation becomes
> needless
> obfuscation; I'm not comfortable enough with svn code to know where that
> point is.
I think we use fprintf(stderr, ...) only for fatal errors that occur before we
can use the svn_utf calls -- usually that means before the call to
apr_initialize. This is not the case here. I do believe we'd want to add a new
error code for unsupported options, and use that. However, for the time being, I
think your patch is O.K.
Now all we need to do is decide finally whether we want it in the code or not. :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 22 16:50:49 2003