Re: [PATCH] svnadmin create --owner --group patch (second attempt)

John Peacock wrote:

> Guess who hasn't had any Internet access for the last few days (HINT:
> I live just outside of Washington, DC)...
>
> Here is my second suggested patch to enable svnadmin to create
> repositories with appropriate ownership/rights. This version now
> ignores those options (and prints a warning) for any platform without
> chmod/setuid/setgid.
>
> I still haven't learned Python, so there are no tests. Pointers to a
> test I can steal^Hlearn from appreciated...

Try getopt_tests.py.

>+ if (opt_state->owner_id)
>+ {
>+#if !( HAVE_UMASK && HAVE_SETUID && HAVE_SETGID )
>
>
Urgh. We don't use spaces after open parens or before close parens.

>+ printf ("WARNING: --owner and --group unavailable under Win32");
>
>
   1. This warning isn't restricted to Win32 any more
   2. Use svn_handle_warning instead of printf

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org