On Wed, 10 Sep 2003, B. W. Fitzpatrick wrote:
> Martin Furter <mf@rola.ch> writes:
>
> > AUTOPROPS_FNMATCH
> >
> > This version uses apr_fnmatch. It can't have default properties for
> > filenames that do not match. The first match which is found wins.
> >
> > The problem is that the config is stored in APR hashes and i can't
> > test the matches in the order as they are in the config file. So if
> > i put the following to rules into the config:
> >
> > Makefile* = svn:eol-style=LF
> > *.jpg = svn:mime-type=image/jpeg
> >
> > Then if i add 'Makefile.jpg' both rules can match and it is not
> > defined which one will be first found in the config hash.
>
> I'm going to focus on this one because I think it's the best way to go.
>
> However, I think that all matches should be applied. For example
>
> header-* = owner=fitz@red-bean.com
> *.jpg = svn:mime-type=image/jpeg
>
> So header.jpg would get both the owner and the svn:mime-type prop set.
> Any reason why you wouldn't do all matches?
The propblem is that some combinations don't make sense, but would be
needed (at least for me).
At the moment i have the following rules in my config:
Makefile* = svn:eol-style=LF
*.cpp = svn:eol-style=native
*.jpg = svn:mime-type=image/jpeg
The behaviour of 'Makefile.cpp' is undefined, for 'Makefile.jpg' i'd
get a combination of eol-style and mime-type which doesn't make sense.
Ofcourse if the user knows that he must not use names which conflict
he can choose filenames accordingly.
> I haven't looked at your patch yet, but I'd really like to see some
> tests for them. :)
I'll try to make tests as soon as it's clear which version should be
implemented
Thanks
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 11 16:19:46 2003