Re: svn commit: rev 7004 - branches/svnserve-thread-pools/subversion/svnserve

Garrett Rooney wrote:

> Branko Čibej wrote:
>
>>> I don't recally any actual concerns being voiced...
>>
>>
>>
>> I simply wasn't ready to commit them, because those patches are broken.
>> Just FYI, a correct implementation of condition variables on Windows
>> doesn't look even remotely like what's in APR now, or what mbk's or my
>> patches look like. I know a couple of places where I could get such an
>> implementation, but the trouble is that the licenses they're distrbuted
>> under makes them unusable for APR. Which means that I can't even look at
>> them. I have seen the algorithm described, though, so I'm (slowly)
>> taking it from there.
>>
>
> I don't know if this implementation fixes whatever races you're
> concerned about (my win32-fu is weak), but you might want to take a
> look at the boost.threads condition class, as it seems to be under an
> acceptable license.
>
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/boost/boost/libs/thread/src/condition.cpp
>

Thanks, I've already done that. :-) The ones I haven't looked at are
pthreads-win32 (GPL) and ACE (some IBM license, supposed to be free but
you never know).

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org