Re: [PATCH] [cvs2svn] Code cleanup - eliminate duplicate code

On Mon, Aug 25, 2003 at 05:50:48PM +0100, Max Bowsher wrote:
> Michael Wood wrote:
> > On Sat, Aug 23, 2003 at 11:41:09AM +0100, Max Bowsher wrote:
> >> * tools/cvs2svn/cvs2svn.py (RepositoryMirror.delete_path):
> >> Restructure "if" statement to eliminate duplicate code.
> >>
> >> Index: cvs2svn.py
> >> ===================================================================
> >> [snip] - if new_key:
> >> + if new_key == None:
> >
> > Shouldn't that be "if new_key is None:"?
>
> Does it make any difference?

Well, in general, "==" is not the same as "is".

> I don't think it does.

You're probably right.

-- 
Michael Wood <mwood@its.uct.ac.za>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org