On Fri, 2003-08-15 at 21:19, Eric Gillespie wrote:
> I'm passing CPPFLAGS to cc(1). The rest of the command to run is
> pulled from Python's Makefile, hard-coded for Java, and i don't
> know where it comes from for Perl. Does that make sense nwo?
Clearer, yes.
> > And the first and third changes don't seem appropriate;
> > changing "FOO = @FOO@" to "FOO = @FOO@ otherstuff" is hackish.
>
> Heh, the first and third are the only ones i'm concerned with :).
> This style is used elsewhere in the file, for example in the
> definition of CPPFLAGS itself. What would you suggest doing
> instead?
Well, it's better to perpetuate existing hackishness than it is to
introduce completely new hackishness, but it's still distasteful. When
you have a variable substituted into a Makefile by a configure script,
it shouldn't change name or value during the assignment, or people are
more likely to get confused when debugging build problems. Better to
pick different variable names for the extended values.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 16 03:28:37 2003