Re: [PATCH] Put CPPFLAGS in SWIG_PY_COMPILE and friends

Greg Hudson <ghudson@MIT.EDU> writes:

> On Fri, 2003-08-15 at 20:03, Eric Gillespie wrote:
> > +SWIG_PY_COMPILE = @SWIG_PY_COMPILE@ $(CPPFLAGS)
> > +SWIG_JAVA_COMPILE = $(CC) -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -fPIC
> $(CPPFLAGS)
> > +SWIG_PL_COMPILE = @SWIG_PL_COMPILE@ $(CPPFLAGS)
>
> I'm not sure I understand the spirit of the change; passing C
> preprocessor flags to Python, Java, or Perl compile commands seems
> strange.

I'm passing CPPFLAGS to cc(1). The rest of the command to run is
pulled from Python's Makefile, hard-coded for Java, and i don't
know where it comes from for Perl. Does that make sense nwo?

> And the first and third changes don't seem appropriate;
> changing "FOO = @FOO@" to "FOO = @FOO@ otherstuff" is hackish.

Heh, the first and third are the only ones i'm concerned with :).
This style is used elsewhere in the file, for example in the
definition of CPPFLAGS itself. What would you suggest doing
instead?

--
Eric Gillespie <*> epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day. Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 16 03:20:22 2003