Re: svn commit: rev 6725 - trunk/subversion/mod_dav_svn

sussman@tigris.org writes:
> +
> + /* ### for now, our global VCC has no such property. */
> + if (resource->type == DAV_RESOURCE_TYPE_PRIVATE
> + && resource->info->restype == DAV_SVN_RESTYPE_VCC)
> + {
> + return DAV_PROP_INSERT_NOTSUPP;
> + }

Might it be worth making a macro (at least for the condition portion),
since this test gets repeated so much? The scope of the macro could
be limited to just dav_svn_insert_prop().

Then the macro definition could be preceded by a detailed comment
explaining the purpose of the check, yet the code in the function body
would remain concise...

Just a thought,
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 14 06:25:53 2003