Re: request for comments from developers about issues 1004 and 901

"SteveKing" <steveking@gmx.ch> writes:

> add a new callback function to svn_client_ctx_t
>
> svn_progress_notify_func_t progress_func;
> void *progress_baton;
>
> the progess function would look like this:
>
> typedef void (*svn_progress_notify_func_t)
> (void *baton,
> const char * url1,
> const char * url2,
> svn_progress_val_t item_progress,
> svn_progress_val_t item_total,
> svn_progress_unit,
> svn_progress_val_t overall_progress,
> svn_progress_val_t overall_total,
> svn_progress_unit);
>
> with svn_progress_val_t being an unsigned long and
> svn_progress_unit being an enum with members
> like "bytes", "nothing" (for just displaying percent values),
> "files", etc.

Any reason why this is separate from the existing notify callback?
The existing notify callback has several "actions". How about
changing the existing mechanism to use a union of structs, rather than
a list of parameters. Then it would be fairly simple to extend it to
handle progress notification as well.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org