[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: request for comments from developers about issues 1004 and 901

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-08-12 03:27:30 CEST

"SteveKing" <steveking@gmx.ch> writes:

> add a new callback function to svn_client_ctx_t
>
> svn_progress_notify_func_t progress_func;
> void *progress_baton;
>
> the progess function would look like this:
>
> typedef void (*svn_progress_notify_func_t)
> (void *baton,
> const char * url1,
> const char * url2,
> svn_progress_val_t item_progress,
> svn_progress_val_t item_total,
> svn_progress_unit,
> svn_progress_val_t overall_progress,
> svn_progress_val_t overall_total,
> svn_progress_unit);
>
> with svn_progress_val_t being an unsigned long and
> svn_progress_unit being an enum with members
> like "bytes", "nothing" (for just displaying percent values),
> "files", etc.

Any reason why this is separate from the existing notify callback?
The existing notify callback has several "actions". How about
changing the existing mechanism to use a union of structs, rather than
a list of parameters. Then it would be fairly simple to extend it to
handle progress notification as well.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 12 03:28:20 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.