Re: My Unapplied Patches [was Re: [PATCH] Issue #1297 Fix - Rev. 5]

On Mon, 11 Aug 2003 kfogel@collab.net wrote:

> Shlomi Fish <shlomif@vipe.stud.technion.ac.il> writes:
> > I'd rather not. It makes it more difficult to apply the patch.
>
> Have you tried it? :-) The 'patch' program just ignores the non-patch
> portion.
>

Oh OK. It's still easier for me to maintain the files my way, because then
I can simply redirect svn diff to the file and write the log in a separate
message.

> > add-config-dir.patch.txt and add-config-dir.log.txt are no longer valid
> > and rather broken.
>
> Then no reason to keep them in the dir...
>

Removed.

> > Use add-config-dir-rev2. What this patch does is add
> > a --config-dir option to the command line clients (and underlying
> > libraries) to specify an alternative directory where one can find the
> > configuration files. It helps for Issue #1385:
> >
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1385
> >
> > and may be usable in other cases.
>
> Thanks. I'd recommend just naming the patch after 1385, and making a
> comment in the issue.
>

There is already a comment in the issue. I added an issue-1385.html file
that links to the patch and log of add-config-dir.

Regards,

        Shlomi Fish

----------------------------------------------------------------------
Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 11 18:16:24 2003