[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Committing other people's filed patches

From: <kfogel_at_collab.net>
Date: 2003-08-02 02:35:19 CEST

kfogel@collab.net writes:
> Seriously: you have as much "right" to commit as any committer. And
> you are as responsible for what you commit as any committer. So when
> you're unsure of a specific change, you should ask first, and when
> you're pretty confident, you can go ahead and commit it -- this is how
> everyone else operates too. And if there's ever a vote among the full
> committers (rare, but who knows), then your vote counts the same as
> anyone else's.

I guess I should add: you are running 'make check' first, right? Or
to be more complete:

   'make check'
   'make svncheck'
   'make davcheck'

Basically, if a commit breaks the build or the test suite, that's more
embarrassing than if it introduces a subtle bug that no one expected
:-). So for code changes, there are at least these sanity checks to
give you some confidence.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 2 03:13:54 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.