[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Committing other people's filed patches

From: <kfogel_at_collab.net>
Date: 2003-08-02 02:28:17 CEST

Julian Foad <julianfoad@btopenworld.com> writes:
> I looked in the issue tracker today, found a trivial documentation
> patch that had been filed in March, reviewed it, committed, and
> marked the issue as "resolved: fixed" (issue 1217, r6634). Is it OK
> for me to do that? I don't want to abuse my commit rights. Of
> course I will only do this when I am confident that a patch is
> correct and wanted.

Don't be timid :-).

Seriously: you have as much "right" to commit as any committer. And
you are as responsible for what you commit as any committer. So when
you're unsure of a specific change, you should ask first, and when
you're pretty confident, you can go ahead and commit it -- this is how
everyone else operates too. And if there's ever a vote among the full
committers (rare, but who knows), then your vote counts the same as
anyone else's.

You might inadvertently commit something problematic (most of us have
done it once or twice). If that happens, we just revert it and
discuss, no big deal.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 2 03:06:50 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.