Greg Stein <gstein@lyra.org> writes:
> > + # Officially, CVS symbolic names must use a fairly restricted set
> > + # of characters. Unofficially, we don't care if some repositories
> > + # out there don't abide by this, as long as their tags start with
> > + # a letter and don't include '/' or '\' (both of which are
> > + # prohibited by official restrictions anyway).
> > + self.symbolic_name_re = re.compile('^[a-zA-Z][^/\\\\]*$')
>
> That regular expression is constant, so I see no reason to keep compiling a
> new regex object each time. Generally, I like to put these at the global
> level, where they are compiled just once.
That makes sense. I forgot that CollectData isn't like a lot of the
other classes in that file, in that many CollectData objects are
created. Thanks!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 16 17:33:58 2003