Re: Tests on Windows

Branko Čibej wrote:

>D.J. Heap wrote:
>
>
>
>>After running tests (5 repeats) on 3 different machines, the only
>>test that is failing consistently is svnlook_test 3:
>>
>>
>>PASS: svnlook_tests.py 2: delete file in moved dir
>>CMD: svnadmin.exe "create" "repositories/svnlook_tests-3"
>>"--bdb-txn-nosync" <TIME = 1.402000>
>>CMD: svnadmin.exe dump "local_tmp/repos" | svnadmin.exe load
>>"repositories/svnlook_tests-3" <TIME = 0.000000>
>>CMD: svn.exe "co" "--username" "jrandom" "--password" "rayjandom"
>>"file:///D:/Projects/Subversion/junk/subversion/tests/clients/cmdline/repositories/svnlook_tests-3"
>>"working_copies/svnlook_tests-3" <TIME = 2.173000>
>>CMD: svn.exe "propset" "bogus_prop" "bogus_val"
>>"working_copies/svnlook_tests-3/iota" <TIME = 0.080000>
>>CMD: svn.exe "ci" "-m" """" "working_copies/svnlook_tests-3/iota"
>><TIME = 0.081000>
>>svn: Path is not a working copy directory
>>svn: 'D:\Projects\Subversion\junk\subversion\tests\clients\cmdline' is
>>not a working copy
>>FAIL: svnlook_tests.py 3: test the printing of property diffs
>>END: svnlook_tests.py
>>
>>
>
>This looks like a real bug. I'll repeat the tests here and see what happens.
>
Fails on Windows for me, too. And guess what? I think it's those 4
quotes in the comand line:

    CMD: svn.exe "ci" "-m" """" "working_copies/svnlook_tests-3/iota"

My guess is the shell interprets that as two parameters: the first is
the empty log message, the second is a commit target -- the wrong one.
Let's see...

Index: svnlook_tests.py
===================================================================
--- svnlook_tests.py (revision 6464)
+++ svnlook_tests.py (working copy)
@@ -153,7 +153,7 @@
   if errput: raise svntest.Failure
 
   # commit the change
- output, errput = svntest.main.run_svn(None, 'ci', '-m', '""', iota_path)
+ output, errput = svntest.main.run_svn(None, 'ci', '-m', 'log msg', iota_path)
   if errput: raise svntest.Failure
 
   # Grab the diff

Yup, much better. People who write new tests should look at how existing
tests are written, not try to reinvent the wheel. Fix committed in
revision 6466.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org