[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_client/commit.c:remove_tmpfiles()

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-07-10 01:32:09 CEST

kfogel@collab.net writes:

> Well, this is interesting. I simply commented out the
> svn_io_check_path() and the conditional guard, so that we'd
> unconditionally run svn_io_file_remove() on the tempfile.
> To my surprise, that caused a bunch of test failures (see below).
> Maybe there's some code path by which tmpfiles are removed early?

My guess is that most of the time the files are removed before
remove_tmpfiles is called. I suspect that only after certain commit
failures, a commit race leading to an fs merge failure say, will there
ever be files for remove_tmpfiles to delete.

You could probably reinstate the conditional guard, replace the
svn_io_file_remove with an abort, and still have the regression tests
pass--however stress.pl may well fail.

> Next thing to try is the APR_EEXIST error check; perhaps all of the
> errors below were simply due to that.

That should be OK.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 10 01:33:05 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.