[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_client/commit.c:remove_tmpfiles()

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2003-07-10 00:46:26 CEST

On Wed, Jul 09, 2003 at 01:29:19PM -0500, cmpilato@collab.net wrote:
> kfogel@collab.net writes:
> > I'm going to comment out the svn_io_check_path() and make the removal
> > unconditional, then run the test suite. But that won't necessarily
> > provide a 100% reliable answer, so I also wanted to ask here, in case
> > anyone remembers anything about the logic of this code...
> Also, note that we could just check the error response from
> svn_io_remove_file() for APR_EEXIST (or whatever the error is that
> means "it ain't here"), and ignore that error. That would still save
> us the stat().

I can't think of anything wrong with this approach, and it seems better
than ignoring all errors.

It is certainly possible that the file could not exist: it may have been
removed by some other process. It is also possible that the remove
could fail (on Win32, it could be locked by another process). We should
not error if the file has already been removed, and we should error if we
are unable to remove it.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 10 00:46:13 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.