[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oops.. here is the patch

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-07-08 18:10:22 CEST

On Tue, 2003-07-08 at 07:33, Greg Stein wrote:
> On Tue, Jul 08, 2003 at 11:54:09AM +0100, Mukund wrote:
> >...
> > + /* Cache open repository. Key it off by root_path, which should be more
> > + * unique than the fs_path, given that two Locations may point to the
> > + * same repository.
> > + */
> > + repos_key = apr_pstrcat(r->pool, "mod_dav_svn:", root_path, NULL);
> You know... I still don't understand this. You *want* to use the same key
> whenever possible. So why shoot for something "more unique" ?? If two
> Locations refer to the same repos, and requests come in over the connection
> for each of those Locations, then they ought to use the same FS!

Could virtual hosting cause the same fs_path to refer to two different
repositories? (If that's the case, then the code is more correct, but
the comment is severely confused.)

Incidentally, I feel a little weird about a performance improvement
patch which *relies* on mod_dav not clearing the pool between requests.
Or am I misunderstanding how this works?

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 8 18:11:36 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.