[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oops.. here is the patch

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-07-08 13:33:43 CEST

On Tue, Jul 08, 2003 at 11:54:09AM +0100, Mukund wrote:
> + /* Cache open repository. Key it off by root_path, which should be more
> + * unique than the fs_path, given that two Locations may point to the
> + * same repository.
> + */
> + repos_key = apr_pstrcat(r->pool, "mod_dav_svn:", root_path, NULL);

You know... I still don't understand this. You *want* to use the same key
whenever possible. So why shoot for something "more unique" ?? If two
Locations refer to the same repos, and requests come in over the connection
for each of those Locations, then they ought to use the same FS!

Mind you, we don't want to use an FS simultaneously across threads, but that
isn't the case here.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 8 13:28:32 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.