Re: Tackling Issue 571

Shlomi Fish <shlomif@vipe.stud.technion.ac.il> writes:

> I'm trying to solve issue 571:
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=571
>
> Using gdb, I've tracked the offending code to libsvn_repos/delta.c:914 :

Oh, no you haven't. You just think you have.

> So, how should I tell delete no to emit a message, and tell
> add_file_or_dir to emit a replace one? Should I implement the same logic
> in the delete_entry and close_file handlers as exists here to get the
> distance? Or should I add a parameter to the callback? (thus maybe
> breaking the API)

Dude, you're looking on the other side of the network for a
client-side UI bug. dir_delta() and friends is doing the right
thing. This "bug" can be handled in one of two ways:

   - close it as invalid, because the notification is a true
     representation of what's going on (a deletion of a path followed
     be a re-addition of that same path), or

   - cache the fact that a path is being deleted, and hold off on
     displaying that fact until the last possible moment, or until
     that path is re-added, at which time use the 'R' notification
     once instead of a 'D' and an 'A'.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 1 17:18:23 2003