[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Tackling Issue 571

From: Shlomi Fish <shlomif_at_vipe.stud.technion.ac.il>
Date: 2003-07-01 13:04:06 CEST

I'm trying to solve issue 571:


Using gdb, I've tracked the offending code to libsvn_repos/delta.c:914 :

              else if ((distance == -1) && (! c->ignore_ancestry))
                  SVN_ERR (delete (c, dir_baton, t_fullpath, subpool));
                  SVN_ERR (add_file_or_dir (c, dir_baton, target_path,
                                            t_entry->name, subpool));

Now, delete and add_file_or_dir call callbacks in the upper layers, which
do not accept a flag that indicates the distance variable.

So, how should I tell delete no to emit a message, and tell
add_file_or_dir to emit a replace one? Should I implement the same logic
in the delete_entry and close_file handlers as exists here to get the
distance? Or should I add a parameter to the callback? (thus maybe
breaking the API)


        Shlomi Fish

Shlomi Fish shlomif@vipe.technion.ac.il
Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two
doctors away.

        Falk Fish

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 1 13:05:43 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.