Branko Cibej wrote:
> Russell Yanofsky wrote:
>> On a
>> semi-related note, can you possibly look into commiting my "fix for
>> FileDiff class in python bindings" patch [1]? It's pretty
>> straightforward and it's neccessary for ViewCVS to be able to work
>> with Subversion on Windows.
>>
>>
> I haven't done any work on the bindings themselves, so I don't feel
> competent to approve patches in that area. However, I _can_ say that
> your patch violates Python naming conventions. Apart from that, it
> looks O.K. to me, if a bit weird -- but that's Windows for you...
>
> What I don't understand is a) why the FileDiff class doesn't use the
> internal diff library, since we have it? We can just ignore the diff
> options for now, can't we?
I think ViewCVS uses the diff options, although that isn't really a reason to
implement them in the python bindings. Anyway, thanks for looking into this.
I'll fix the function names and resubmit my weird patch sometime soon. ;)
- Russ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 25 06:24:48 2003