Re: [PATCH] Generating VC6 project files for swig bindings

Russell Yanofsky wrote:

>Branko Cibej wrote:
>
>
>>Committed in revision 6329. Thanks!
>>
>>The next step is to add dependencies on the headers converted by the
>>.i files, so that SWIG regenerates the bindings correctly when the
>>headers change.
>>
>>
>
>I think I know how that can be done for VC6. I'll work on that later today.
>
Cool.

> On a
>semi-related note, can you possibly look into commiting my "fix for FileDiff
>class in python bindings" patch [1]? It's pretty straightforward and it's
>neccessary for ViewCVS to be able to work with Subversion on Windows.
>
>
I haven't done any work on the bindings themselves, so I don't feel
competent to approve patches in that area. However, I _can_ say that
your patch violates Python naming conventions. Apart from that, it looks
O.K. to me, if a bit weird -- but that's Windows for you...

What I don't understand is a) why the FileDiff class doesn't use the
internal diff library, since we have it? We can just ignore the diff
options for now, can't we?

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org