[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Tests fail with DAV (bad PROPFIND) => path_driver.c is broken?

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-06-22 21:12:35 CEST

Steve James <s.james@bigfoot.com> writes:

> On Sunday 22 Jun 2003 7:24 pm, Philip Martin wrote:
>> Steve James <s.james@bigfoot.com> writes:
>> > 127.0.0.1 - - [22/Jun/2003:16:04:49 +0100] "PROPFIND
>> > /repositories/basic_tests-3/A/D/D HTTP/1.1" 404 323
>>
>> I see this as well. Reverting r6313 makes the failures go away,
>> although I can't see what is wrong with the code.
>
> Hello Philip. I'm still peering at this, but it's hard going.

I believe this fixes the problem. I'm running the regression tests
now

Index: subversion/libsvn_delta/path_driver.c
===================================================================
--- subversion/libsvn_delta/path_driver.c (revision 6316)
+++ subversion/libsvn_delta/path_driver.c (working copy)
@@ -217,11 +217,12 @@
       svn_path_split (path, &pdir, &bname, iterpool);
       if (strlen (pdir) > common_len)
         {
- const char *rel = pdir;
           const char *piece = pdir + common_len + 1;
 
           while (1)
             {
+ const char *rel = pdir;
+
               /* Find the first separator. */
               piece = strchr (piece, '/');
 

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 22 21:13:36 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.