[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Tests fail with DAV (bad PROPFIND) => path_driver.c is broken?

From: Steve James <s.james_at_bigfoot.com>
Date: 2003-06-22 20:47:06 CEST

On Sunday 22 Jun 2003 7:24 pm, Philip Martin wrote:
> Steve James <s.james@bigfoot.com> writes:
> > - - [22/Jun/2003:16:04:49 +0100] "PROPFIND
> > /repositories/basic_tests-3/A/D/D HTTP/1.1" 404 323
> I see this as well. Reverting r6313 makes the failures go away,
> although I can't see what is wrong with the code.

Hello Philip. I'm still peering at this, but it's hard going. If you trace
svn_delta_path_driver() and watch the calls to open_dir(), you'll see that,
when running basic_tests.py 3, the directory 'D' is opened twice. This
doesn't make sense to me. It corresponds with the bad "PROPFIND ...A/D/D"
transaction. I think the immediate while loop around the open is broken.
What's foxing me is that if I correct the loop and make it behave as I think
is should (such that directories "D" and "D/G" are opened) the test passes
for DAV *but* fails for local files! Perhaps svn is relying on the
'incorrect' behaviour? I'm struggling to see what this module is actually
supposed do! This bit of code is *not* very nice!

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 22 20:42:34 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.