Re: [PATCH] -std-c89 not supported

On Wed, Jun 18, 2003 at 01:36:34PM +0200, Sander Striker wrote:
> > From: Justin Erenkrantz [mailto:justin@erenkrantz.com]
> >
> > I meant that -std=c89 shouldn't be passed to the compiler ever as APR
> > explicitly relies upon some semantics that may render the OS's includes
> > non-C89 compliant. Therefore, it isn't a check that we should turn on even in
> > maintainer mode. -- justin
>
> I agree. I'll yank this somewhere today if noone beats me to it.

I disagree! This option gives useful information sometimes. Just because it
can't work on _some_ platforms is no reason to disable it on _all_ of them.
I'd be much happier with either
1) Disabling it on platforms where it is known to not work, or
2) Enabling it on platforms where it is known to work.

I think 2 is probably the better option, since that way we won't have to deal
with user issues whenever a new platform where it doesn't work is discovered.

Given 2, we know that it works on linux, I would assume that it works on
FreeBSD since sussman uses FreeBSD, and so it presumably works on the other
*BSD's too.

Everything else is suspect, but since most of the people working on Subversion
use one of those platforms, it still buys us a lot of coverage.
>

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org