[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Dump fails on big repository with svn 0.24

From: <cmpilato_at_collab.net>
Date: 2003-06-17 16:48:12 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> "D.J. Heap" <djheap@dhiprovo.com> writes:
>
> > From: sussman@collab.net [mailto:sussman@collab.net]
> > > Wow, I wish someone had pointed this out before! Looks like a classic
> > > case of not using subpools correctly.
> >
> > I just noticed it this week -- I'm not sure if it's been doing that
> > forever or is just a recent change. This week I've been doing heavy
> > backup/restore setup and testing, which is why I was watching more
> > carefully than usual.
>
> Well, a couple of weeks ago, cmpilato changed the "engine" behind the
> dumper -- instead of svn_repos_dir_delta(), it's now running
> svn_repos_replay(). I bet there's a pool bug in there...

Most definitely. The code I abstracted out of the commit system used
no subpools whatsoever. I had a note to fix that before committing,
but, er, forgot.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 17 16:49:53 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.