[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 6179 - in trunk: . build/ac-macros

From: Patrick Mayweg <mayweg_at_qint.de>
Date: 2003-06-11 06:27:14 CEST

Hi Karl,

kfogel@collab.net wrote:

> patrick@tigris.org writes:
> > New Revision: 6179
> >
> > Modified:
> > trunk/build/ac-macros/neon.m4
> > trunk/svn-config.in
> > Log:
> > Fix for Issue 751. (references to abs_srcdir and abs_builddir in
> > svn-config)
> Patrick, I don't want to stand in the way of work getting done, but
> should point out that your commit access is for the Java bindings.
> The limitation is not because anyone thinks badly of your coding, just
> that we hadn't seen enough patches from you to say "Give this guy full
> commit access" :-).

I am sorry that you feal that way. I have posted the modifications twice to the mail list. But nobody cared to answer. This patch is needed to configure
the java-bindings.

> Committing directly to other areas is still okay, but the log message
> should say "Reviewed by so-and-so", where so-and-so is some committer
> with expertise in the relevant domain. (Possibly that happened in
> this case, and you just forgot to mention it in the log message?)

I am more than happy, if anybody who has expertise in this area would like to review my changes.

> Or, maybe some committer wants to review it after the fact, which
> would also be fine. Doing things in commit-then-review order is okay,
> as long as *someone* is committed to reviewing it...

How do I find someone to review my changes, if nobody answers to my mail to the mailing list ?

> That's all -- not a big deal, and I'm certainly not asking you to
> revert it or anything. Just pointing it out for next time.
> (I don't have time/competence to review it myself right now,
> unfortunately.)
> By the way, were you aware that as of rev 5859, svn-config is not
> installed? So your change won't have any effect by itself.

svn-config does not need to be installed for the patch to work in the current form.

> -Karl


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 11 06:28:07 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.