patrick@tigris.org writes:
> New Revision: 6179
>
> Modified:
> trunk/build/ac-macros/neon.m4
> trunk/svn-config.in
> Log:
> Fix for Issue 751. (references to abs_srcdir and abs_builddir in
> svn-config)
Patrick, I don't want to stand in the way of work getting done, but
should point out that your commit access is for the Java bindings.
The limitation is not because anyone thinks badly of your coding, just
that we hadn't seen enough patches from you to say "Give this guy full
commit access" :-).
Committing directly to other areas is still okay, but the log message
should say "Reviewed by so-and-so", where so-and-so is some committer
with expertise in the relevant domain. (Possibly that happened in
this case, and you just forgot to mention it in the log message?)
Or, maybe some committer wants to review it after the fact, which
would also be fine. Doing things in commit-then-review order is okay,
as long as *someone* is committed to reviewing it...
That's all -- not a big deal, and I'm certainly not asking you to
revert it or anything. Just pointing it out for next time.
(I don't have time/competence to review it myself right now,
unfortunately.)
By the way, were you aware that as of rev 5859, svn-config is not
installed? So your change won't have any effect by itself.
-Karl
> * build/ac-macros/neon.m4
> added SVN_NEON_INCLUDES_SVN_CONFIG for use in svn-config script.
> added NEON_LIBS_SVN_CONFIG for use in svn-config script.
> SVN_NEON_INCLUDES and NEON_LIBS were used for this purpose.
> These are also used for Makefile which has a different syntax.
>
> * svn-config.in
> changed SVN_NEON_INCLUDES to SVN_NEON_INCLUDES_SVN_CONFIG.
> changed NEON_LIBS to NEON_LIBS_SVN_CONFIG.
>
>
>
> Modified: trunk/build/ac-macros/neon.m4
> ==============================================================================
> --- trunk/build/ac-macros/neon.m4 (original)
> +++ trunk/build/ac-macros/neon.m4 Tue Jun 10 00:05:08 2003
> @@ -53,6 +53,8 @@
> echo "Using neon found in source directory."
> SVN_NEON_INCLUDES=-'I$(abs_srcdir)/neon/src'
> NEON_LIBS="\$(abs_builddir)/neon/src/libneon.la"
> + SVN_NEON_INCLUDES_SVN_CONFIG="-I$abs_srcdir/neon/src"
> + NEON_LIBS_SVN_CONFIG="$abs_builddir/neon/src/libneon.la"
>
> dnl Configure neon --------------------------
> # The arguments passed to this configure script are passed down to
> @@ -85,8 +87,11 @@
> changequote(<<, >>)dnl
> CFLAGS="$CFLAGS `$SHELL $abs_builddir/neon/neon-config --cflags | sed -e 's/-I[^ ]*//g'`"
> SVN_NEON_INCLUDES="$SVN_NEON_INCLUDES `$SHELL $abs_builddir/neon/neon-config --cflags | sed -e 's/-D[^ ]*//g'`"
> - changequote([, ])dnl
> svn_lib_neon="yes"
> + NEON_LIBS_SVN_CONFIG="$NEON_LIBS_SVN_CONFIG $NEON_LIBS_NEW"
> + SVN_NEON_INCLUDES_SVN_CONFIG="$SVN_NEON_INCLUDES_SVN_CONFIG `$SHELL $abs_builddir/neon/neon-config --cflags | sed -e 's/-D[^ ]*//g'`"
> + changequote([, ])dnl
> +
> fi
>
> SVN_SUBDIRS="$SVN_SUBDIRS neon"
> @@ -108,6 +113,8 @@
>
> AC_SUBST(SVN_NEON_INCLUDES)
> AC_SUBST(NEON_LIBS)
> + AC_SUBST(SVN_NEON_INCLUDES_SVN_CONFIG)
> + AC_SUBST(NEON_LIBS_SVN_CONFIG)
> ])
>
> dnl SVN_NEON_CONFIG()
>
> Modified: trunk/svn-config.in
> ==============================================================================
> --- trunk/svn-config.in (original)
> +++ trunk/svn-config.in Tue Jun 10 00:05:08 2003
> @@ -22,10 +22,10 @@
> libdir="@libdir@"
> includedir="@includedir@"
>
> -LIBS="@NEON_LIBS@ @SVN_APRUTIL_EXPORT_LIBS@ @SVN_APR_EXPORT_LIBS@ @SVN_DB_LIBS@ @LIBS@"
> +LIBS="@NEON_LIBS_SVN_CONFIG@ @SVN_APRUTIL_EXPORT_LIBS@ @SVN_APR_EXPORT_LIBS@ @SVN_DB_LIBS@ @LIBS@"
> CFLAGS="@CFLAGS@"
> CPPFLAGS="@CPPFLAGS@"
> -INCLUDES="@SVN_NEON_INCLUDES@ @SVN_DB_INCLUDES@ @SVN_APR_INCLUDES@ @SVN_APRUTIL_INCLUDES@"
> +INCLUDES="@SVN_NEON_INCLUDES_SVN_CONFIG@ @SVN_DB_INCLUDES@ @SVN_APR_INCLUDES@ @SVN_APRUTIL_INCLUDES@"
> LDFLAGS="@LDFLAGS@"
>
> SVN_SOURCE_DIR="@abs_srcdir@"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 10 17:55:56 2003